[Improvement] Shutdown the grpc executors pool when closing#83
Merged
roryqi merged 1 commit intoapache:masterfrom Jul 26, 2022
Merged
[Improvement] Shutdown the grpc executors pool when closing#83roryqi merged 1 commit intoapache:masterfrom
roryqi merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
============================================
- Coverage 56.39% 56.37% -0.02%
Complexity 1173 1173
============================================
Files 149 149
Lines 7953 7955 +2
Branches 761 762 +1
============================================
Hits 4485 4485
- Misses 3226 3228 +2
Partials 242 242
Help us with your feedback. Take ten seconds to tell us how you rate us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
[Improvement] Shutdown the grpc executors pool when closing
Why are the changes needed?
Although the executor pool is used in grpc, but the grpc server won't take ownership of the given executor. It's caller's responsibility to shut down the executor when it's desired.
Does this PR introduce any user-facing change?
No
How was this patch tested?
No need.